Apply CS fixes #200
Open
Apply CS fixes #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deviantintegral
force-pushed
the
cs-fixes
branch
from
fc5804d
to
2860d7d
Compare
|
Well this fixed those tests, but PHP builds are failing. We need the FQCN's for the serializer. |
|
@marcoscano any idea what's up with the missing expected CI reports? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have expected this to fail the PR where things were upgrade. It's surprising, I no longer see any job data for PRs like this one: #192
I'm not sure I like removing the fqcn's from docblocks on imported classes, but I don't see an easy way to disable that and if Symfony is doing it we may as well follow.